Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use preprocessed t and xy instead of as_list_with_timestamps #134

Merged
merged 7 commits into from
Apr 13, 2020

Conversation

tybug
Copy link
Contributor

@tybug tybug commented Apr 9, 2020

should be identical (though I haven't tested, we need to add a test case for aim correction). This should also be done for ur calculation so we can finally be rid of as_list_with_timestamps.

instead of as_list_with_timestamps
Copy link
Contributor

@InvisibleSymbol InvisibleSymbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review lines you didn't change but you need to update the documentation, just do the same thing I did on the macro brancho (right that thing still exists aaaaaaaaaaaaaaaaaaaa)

def aim_correction(replay, max_angle, min_distance):
"""
Calculates the angle between each set of three points (a,b,c) and finds
points where this angle is extremely acute neither ``|ab|`` or
``|bc|`` are
small.
Parameters
----------
replay: :class:`~.Replay`
A Replay object.
max_angle: float
Consider only (a,b,c) where ``∠abc < max_angle``
min_distance: float
Consider only (a,b,c) where ``|ab| > min_distance`` and
``|ab| > min_distance``.

Copy link
Contributor

@InvisibleSymbol InvisibleSymbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/test.py Outdated Show resolved Hide resolved
tests/test.py Outdated Show resolved Hide resolved
Copy link
Contributor

@InvisibleSymbol InvisibleSymbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tybug tybug merged commit 26132f0 into master Apr 13, 2020
@tybug tybug deleted the use-preprocessed-replay-data branch April 13, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants