-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use preprocessed t and xy instead of as_list_with_timestamps #134
Conversation
instead of as_list_with_timestamps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review lines you didn't change but you need to update the documentation, just do the same thing I did on the macro brancho (right that thing still exists aaaaaaaaaaaaaaaaaaaa)
circlecore/circleguard/investigator.py
Lines 70 to 85 in 75662cc
def aim_correction(replay, max_angle, min_distance): | |
""" | |
Calculates the angle between each set of three points (a,b,c) and finds | |
points where this angle is extremely acute neither ``|ab|`` or | |
``|bc|`` are | |
small. | |
Parameters | |
---------- | |
replay: :class:`~.Replay` | |
A Replay object. | |
max_angle: float | |
Consider only (a,b,c) where ``∠abc < max_angle`` | |
min_distance: float | |
Consider only (a,b,c) where ``|ab| > min_distance`` and | |
``|ab| > min_distance``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
should be identical (though I haven't tested, we need to add a test case for aim correction). This should also be done for ur calculation so we can finally be rid of
as_list_with_timestamps
.