add fuzzy mods utility method #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went back and forth on the api design for this one...I considered adding a new mod class that would provide a set of
ModCombinations instead of just one, so you would do something likeand have
mbe the top 10 for each of HD, HDDT, HDEZ, and HDDTEZ.But that dirtied the waters far too much. I was trying to hide too much from the consumers when the right way to go about this is provide a method that creates these "fuzzy" mod sets for you, and then you have total control over what to do with them (someone may want to specify different spans for different mods, for instance).