Add SSH banner as a metric in the lua ssh2 check #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -267,6 +267,9 @@ function initiate(module, check) | |||
| local banner = e:read("\n") | |||
| if banner == nil then return cerr("failed to read SSH banner") end | |||
|
|
|||
| banner = banner:gsub("%s+$", "") | |||
| check.metric_string("banner", banner) | |||
There was a problem hiding this comment.
I wouldn't modify the banner variable.
drop the first line and just do:
check.metric_string("banner", banner:gsub("%s+$", ""))
|
When I do that, I get a "wrong number of arguments" error. |
|
Using a local variable to get the trimmed version of the banner in. |
postwait
added a commit
that referenced
this pull request
May 11, 2015
Add SSH banner as a metric in the lua ssh2 check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already reading the banner; would be nice to have it as a metric.