-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for circt 2500cf570bbc6c6d45940466f9421e93d3a49132 #12
Conversation
(still Timed Out Test: CIRCT-HLS cosim :: suites/Dynamatic/insertion_sort/tst_insertion_sort.c) Add build.sh for bash build under Ubuntu 22.04.1 LTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very very much for this! Regular bumps are important for this repo, so glad to have help with this.
wrt. the cosim test that is failing - no worries, it's probably due to some upstream logical changes. It's more important that this repo gets up and running.
To improve things even further, would you mind:
- adding a
circt_tag.txt
file in the base of this repository which points to the latest CIRCT version that we're tracking (i,e. the commit hash of your bump). - modify
README.md
to describe this version as our "known good" version (at the place where (after this). - For a+ effort, modify our CI builds such that they will load this tag file and use that as the commit hash for the CIRCT checkout
Added "circt_tag.txt". CIRCT tag file now used by CI build via juliangruber/read-file-action@v1 Modified README.md with CIRCT version and failure case. Cleaned up unnecessary commenting.
Glad to help! I also appreciate your guiding me through the process. I bumped CIRCT to 062eab31a67c8a8418b2ba9fb4f1814cdca08783 with no issues.
Added this file.
Done. I also added a line about
I used I cleaned up the unneccessary comments. |
I originally ran into the apt-get 404 errors using the I assumed these were due to some eccentricities of |
This was in reference to #11
All tests pass except for cosim insertion_sort (hanging in mlir-cpu-runner):
"Timed Out Test: CIRCT-HLS cosim :: suites/Dynamatic/insertion_sort/tst_insertion_sort.c"
I also added a bash build script "build.sh" for Ubuntu 22.04.1 LTS
Let me know if this is helpful or if further steps/updates should be done. Also open to debugging insertion_sort.c further if you have any hints.
Best regards,
-Tedd