Better handling of 5xx errors: still not perfect as we could add more…

… detailed error messages, but at least the chain of callbacks is not broken as it was before
circuithub · Mar 16, 2012 · 6871a0f · 6871a0f
1 parent eec4521
commit 6871a0f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/octonode/client.coffee b/src/octonode/client.coffee
@@ -39,8 +39,12 @@ class Client
     uri+= if @token then "?access_token=#{@token}" else ''
 
   errorHandle: (res, body, callback) ->
-    body = JSON.parse(body || '{}')
-    # TODO: Unprocessable entity
+    # TODO More detailed HTTP error message
+    return callback(new Error('Error ' + res.statusCode)) if Math.floor(res.statusCode/100) is 5
+    try
+      body = JSON.parse(body || '{}')
+    catch err
+      return callback(err)
     return callback(new Error(body.message)) if res.statusCode is 422
     return callback(new Error(body.message)) if res.statusCode in [400, 401, 404]
     callback null, res.statusCode, body