Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregateMaybeTable and friends #127

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix aggregateMaybeTable and friends #127

merged 1 commit into from
Oct 22, 2021

Commits on Oct 22, 2021

  1. Fix aggregateMaybeTable and friends 

    None of these functions actually worked (they would generate invalid SQL that referenced the inner tag column where it was no longer in scope). The root of the problem was in the Nullifiable instance for the Aggregate context. The new version works, at the cost of grouping by the tag `n + 1` times instead of just once (where `n` is the number of columns in the `MaybeTable`).
    @shane-circuithub
    shane-circuithub committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    22f8f34 View commit details
    Browse the repository at this point in the history