Add support for two forms of PostgreSQL WITH syntax; loop and materialize
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocharles
reviewed
Jun 19, 2022
Comment on lines
+21
to
+28
| loop :: Table Expr a => Query a -> (a -> Query a) -> Query a | ||
| loop base recurse = |
There was a problem hiding this comment.
Tantiziling close to being mfix!
shane-circuithub
force-pushed
the
loop
branch
2 times, most recently
from
e8edb0b
to
a006999
Compare
shane-circuithub
force-pushed
the
window
branch
from
1ae4217
to
5a5bb49
Compare
shane-circuithub
force-pushed
the
window
branch
3 times, most recently
from
1b2908a
to
b789ccb
Compare
shane-circuithub
force-pushed
the
loop
branch
2 times, most recently
from
c76943c
to
e72b2d5
Compare
|
I’d like to use loop for walking trees, is this going to be merged? 🤔 |
shane-circuithub
force-pushed
the
loop
branch
2 times, most recently
from
b0d015a
to
bc17bd7
Compare
shane-circuithub
changed the title
WITH syntax; loop and materialize
shane-circuithub
force-pushed
the
loop
branch
2 times, most recently
from
1f61962
to
ccf09d7
Compare
|
@chrisdone Yes, I've revived this and it should be merged in the next few days. |
Oh, great, thanks! |
ocharles
reviewed
Mar 24, 2023
src/Rel8/Query/Materialize.hs
Outdated
Comment on lines
31
to
33
| -- used more than once. We reserve the right to change the implementation of | ||
| -- 'materialize' to use the newer @WITH foo AS MATERIALIZED bar@ syntax | ||
| -- introduced in PostgreSQL 12 in the future. |
There was a problem hiding this comment.
Could we add:
Suggested change
| -- used more than once. We reserve the right to change the implementation of | |
| -- 'materialize' to use the newer @WITH foo AS MATERIALIZED bar@ syntax | |
| -- introduced in PostgreSQL 12 in the future. | |
| -- used more than once. We reserve the right to change the implementation of | |
| -- 'materialize' to use the newer @WITH foo AS MATERIALIZED bar@ syntax | |
| -- introduced in PostgreSQL 12 in the future. Currently Rel8 does not use | |
| -- @AS MATERIALIZED@ to support earlier PostgreSQL versions. |
I'd like to make it absolutely clear that we don't use that syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.