Fix catListTable and friends #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-circuithub
force-pushed
the
eval
branch
2 times, most recently
from
23d91d0
to
b6b7fb3
Compare
shane-circuithub
force-pushed
the
fix-catlist
branch
from
51c37df
to
350f381
Compare
shane-circuithub
force-pushed
the
fix-catlist
branch
from
350f381
to
90a1e7b
Compare
ocharles
approved these changes
Jun 22, 2021
|
Approved, but could you write a test? |
shane-circuithub
force-pushed
the
eval
branch
2 times, most recently
from
4a20dd3
to
d630639
Compare
The implemtation before would produce incorrect results if tried to get the cartesian product of two queries built out of `unnest`. Which makes sense, because Postgres seems to special case products of `unnest` to have a `ZipList` semantics rather than the normal `[]`. The solution is to use `rebind` (from `Rel8.Query.Evaluate`) to rebind the results of such queries, so there is no `unnest` in the expressions we're `<*>`ing.
shane-circuithub
force-pushed
the
fix-catlist
branch
from
90a1e7b
to
bac704c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation before would produce incorrect results if tried to get the cartesian product of two queries built out of
unnest. Which makes sense, because Postgres seems to special case products ofunnestto have aZipListsemantics rather than the normal[].The solution is to use
rebind(so naturally this depends on #56) to rebind the results of such queries, so there is nounnestin the expressions we're<*>ing.