Useless cache in EventType

[apollo13]

Currently EventType looks like this:

class EventType(type):

    __cache__ = {}

    def __new__(cls, name, bases, ns):
        key = (cls, name, bases)

        try:
            return cls.__cache__[key]
        except KeyError:
            cls = type.__new__(cls, name, bases, ns)

            setattr(cls, "name", ns.get("name", cls.__name__))

            return cls

I couldn't find any code setting something in the __cache__ -- should we just delete it or actually try using it?

[prologic]

Good question. If we don't use this anywhere let's just delete it. I trust you''ve grokked the codebase and found we don't use this at all :) James Mills / prologic E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au

…

On Fri, Jan 20, 2017 at 10:43 PM, Florian Apolloner < ***@***.***> wrote: Currently EventType looks like this: class EventType(type): __cache__ = {} def __new__(cls, name, bases, ns): key = (cls, name, bases) try: return cls.__cache__[key] except KeyError: cls = type.__new__(cls, name, bases, ns) setattr(cls, "name", ns.get("name", cls.__name__)) return cls I couldn't find any code setting something in the __cache__ -- should we just delete it or actually try using it? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#202>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOv-uANip7hdgaLFCI78T2Ez_uaqEajks5rUTiFgaJpZM4Lp1D1> .

[spaceone]

The whole class is useless in python3 because it is defined via __metaclass__ = ...

[apollo13]

Guess we should add a test and use six.with_metaclass then. I wonder if we even need that metaclass, we can set the name by hand in __new__/__init__ of the class?!

[spaceone]

we already do this

[prologic]

Probably the meta class might not be required.

…

On Sat, Jan 21, 2017 at 11:24 Florian Apolloner ***@***.***> wrote: Guess we should add a test and use six.with_metaclass then. I wonder if we even need that metaclass, we can set the name by hand in __new__/__init__ of the class?! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#202 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOv-lrmCVmhOmBbsVRFiWr2QBKXCUk7ks5rUerZgaJpZM4Lp1D1> .

[apollo13]

seems to be the case according to the tests, I'll remove it for now.