Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Code #82

Closed
1 task
prologic opened this issue Jun 1, 2015 · 8 comments · Fixed by #83
Closed
1 task

Cleanup Code #82

prologic opened this issue Jun 1, 2015 · 8 comments · Fixed by #83
Assignees
Milestone

Comments

@prologic
Copy link
Member

prologic commented Jun 1, 2015

  • Run the codebase through autopep8

There are several code modules that aren't PEP8 compliant and we are meant to be following the PEP8 style guide as part of ou "coding standards".

The autopep8 tool will pick up most (if not all) non-compliance.

@prologic prologic added this to the next milestone Jun 1, 2015
@prologic prologic self-assigned this Jun 1, 2015
@prologic prologic added in progress and removed ready labels Jun 1, 2015
@spaceone
Copy link
Contributor

spaceone commented Jun 1, 2015

Let's also remove the "#Package: , #Date: ..., #Author: ..." header. It's untypically for python projects.

@spaceone
Copy link
Contributor

spaceone commented Jun 1, 2015

Make sure to use "git diff -w" after autopep8 → in some scenarios it breaks code.

@prologic
Copy link
Member Author

prologic commented Jun 1, 2015

$ tox
...
_____________________________________________ summary ______________________________________________
  docs: commands succeeded
  py26: commands succeeded
  py27: commands succeeded
  py32: commands succeeded
  py33: commands succeeded
  py34: commands succeeded
  pypy: commands succeeded
  congratulations :)

:)

@prologic
Copy link
Member Author

prologic commented Jun 1, 2015

Re header comments; done :)

prologic added a commit that referenced this issue Jun 1, 2015
@prologic
Copy link
Member Author

prologic commented Jun 1, 2015

Even with 65bb0c9:

$ time tox -r
_____________________________________________ summary ______________________________________________
  docs: commands succeeded
  py26: commands succeeded
  py27: commands succeeded
  py32: commands succeeded
  py33: commands succeeded
  py34: commands succeeded
  pypy: commands succeeded
  congratulations :)

real    15m7.833s
user    3m12.971s
sys 0m10.452s

@prologic
Copy link
Member Author

prologic commented Jun 1, 2015

So if there are no other objections; I'll merge this in:

@prologic
Copy link
Member Author

prologic commented Jun 1, 2015

I'll also run the codebase through autoflake

@prologic
Copy link
Member Author

prologic commented Jun 1, 2015

Going forward (if you haven't seen already) landscape will ensure that we continue to maintain good code quality :)

prologic added a commit that referenced this issue Jun 1, 2015
prologic added a commit that referenced this issue Jun 1, 2015
prologic added a commit that referenced this issue Jun 2, 2015
prologic added a commit that referenced this issue Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants