Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a process for package bug fixes and customisations. #250

Open
tachyons opened this issue Dec 10, 2022 · 2 comments
Open

Create a process for package bug fixes and customisations. #250

tachyons opened this issue Dec 10, 2022 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@tachyons
Copy link
Member

We are currently using https://github.com/CircuitVerse/packages to update packages on our end. This is not ideal due to multiple reasons.

  1. We won't get security fixes from upstream quickly, we need to do that manually
  2. It is difficult to keep track of the changes we made
  3. Rebasing get harder with time

My suggestions are to

  1. Create a list of changes we had to make and keep that list updated for each MR
  2. Create PR to upstream to Each change and link that PR in the above list
  3. If the package is abandoned, consider switching to another package which provides the same functionality
@tachyons tachyons added the documentation Improvements or additions to documentation label Dec 10, 2022
@tachyons tachyons changed the title Create process for package bugfixes and customisations Create a process for package bug fixes and customisations. Dec 10, 2022
@manjotsidhu
Copy link
Member

@aman-singh7 Can we do a test using official packages again to verify if they have fixed the issues we faced regarding inline builders. If it works now, then we are better off using official packages

@aman-singh7
Copy link
Member

Cool 👍 I will test with the official package and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants