New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untangle profile creation and initialisation, and add functionality #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixwoestmann
changed the title
Add option to initialize method to skip profile creation
Untangle profile creation and initialisation, and add functionality
Oct 5, 2023
t-unit
reviewed
Oct 6, 2023
t-unit
reviewed
Oct 6, 2023
android/src/main/kotlin/com/circuskitchens/flutter_datawedge/SinkBroadcastReceiver.kt
Outdated
Show resolved
Hide resolved
android/src/main/kotlin/com/circuskitchens/flutter_datawedge/SinkBroadcastReceiver.kt
Outdated
Show resolved
Hide resolved
t-unit
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix: #22
This PR introduces the following changes:
profileName
is no longer a required parametercreateDefaultProfile
profileName
is now longer required, we are using a generated UUID as a defaultcommandIdentifier
requestActiveProfile
andwaitForActiveProfile
to obtain the active profile from DatawedgerequestProfiles
andwaitForProfiles
to obtain a list of all installed profiles from Datawedge