Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singleton decr leads to a dead-end #686

Open
lambdafu opened this issue Nov 25, 2013 · 1 comment
Open

singleton decr leads to a dead-end #686

lambdafu opened this issue Nov 25, 2013 · 1 comment

Comments

@lambdafu
Copy link
Contributor

Hi,

I can decrement a singleton but not increment it, because the increment has a hard-coded check for singletons and is a no-op for them.

This leads to a broken situation that can not be unbroken without a restart.

Either disallow decr on singletons as well, or allow incr on singleton if numprocesses is 0.
@tarekziade
Copy link
Member

good catch thanks. yeah we should definitely make sure incr and decr are deactivated for singleton watchers

@lambdafu lambdafu mentioned this issue May 22, 2014
Closed
StefanWiechula added a commit to StefanWiechula/circus that referenced this issue Oct 6, 2015
@StefanWiechula
Prevent decr on singleton watcher (just like incr)
7e78d12 
- Includes tests for both incr and decr
- Fixes issue circus-tent#686 for use with circusctl as well
@StefanWiechula StefanWiechula mentioned this issue Oct 6, 2015
Closed
@StefanWiechula StefanWiechula mentioned this issue Oct 13, 2015
Merged
douardda pushed a commit that referenced this issue Jan 12, 2016
Merge pull request #932 from StefanWiechula/issue-686-circusctl-refac…
9747abd 
…tored

Fix issue #686 for circusctl as well (refactored)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarekziade @lambdafu