clean unrecognized zombie like process #638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyway it does not work with the new async architecture. I noticed a first issue, max_age mechanism of watchers is broken. |
| self.notify_event("zombie", {"process_pid": process.pid, | ||
| "time": time.time()}) | ||
| self.processes.pop(process.pid) | ||
| self.kill_process(process) |
There was a problem hiding this comment.
Since the async switch, kill_process is a coroutine so you can't just call self.kill_process, you have to yield it.
BTW, with this kind of dead processes, maybe it would be better to send a SIGKILL signal and not to start a complete shutdown process (SIGTERM, wait graceful_timeout, SIGKILL...).
And what about putting this logic into reap_processes method ?
|
see #641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #568