build fails at host-e2fsprogs with error: conflicting types for ‘copy_file_range’ on Ubuntu 18.04

[cirosantilli]

fee5183

>>> host-e2fsprogs 1.43.4 Building

...

./../misc/create_inode.c:399:18: error: conflicting types for ‘copy_file_range’
 static errcode_t copy_file_range(ext2_filsys fs, int fd, ext2_file_t e2_file,
                  ^~~~~~~~~~~~~~~                         
In file included from ./../misc/create_inode.c:19:0:              
/usr/include/unistd.h:1110:9: note: previous declaration of ‘copy_file_range’ was here
 ssize_t copy_file_range (int __infd, __off64_t *__pinoff,       
         ^~~~~~~~~~~~~~~                                           
Makefile:422: recipe for target 'create_inode.o' failed                 
make[4]: *** [create_inode.o] Error 1                  

A few reports out there:

• buildroot compile failure on Debian Buster (testing) sifive/freedom-u-sdk#52
• https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890716

cannot reproduce on buildroot master:

Patch at: sifive/buildroot#6

Why buildroot, why.

Did not help:

git cherry-pick c4d2c9cafb19312f6d2f2a9bc0740f45b65559c7

[cirosantilli]

To solve, bump e2fsprogs and remove some patches...

git cherry-pick 436291d3f03c5e30610b9f9ac5b797be3348aa45
git cherry-pick a46390537d1b2369c366df4255b81618f016f19e
git cherry-pick 28dd2f2896bff7b861a4272fa343e3f7fa80725c

omg that package is so broken!!!

Maybe the best option is to just git checkout master -- package/e2fsprogs.

This then revealed that host-flex is also broken obviously, so I just checked it out to master, but still problems?

[cirosantilli]

In the end I finally just bumped buildroot to 2018.05 and my woes went away.