Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human readable diff in case of changes and correct sort for portgroups #75

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

banuchka
Copy link
Contributor

@banuchka banuchka commented Feb 8, 2024

Hi,
First of all, I would like to thank you for the module.
I found that the module may add false positive notice events/messages on a puppet agent side.
It is a reproducible case.
As an example I added one more portgroup for the network configuration via yaml and in parallel I added a new portgroup on the host via virsh net-update. Starting from that point I see notices every time I run puppet agent on a client.
The false positives are gone as soon as I do virsh net-destroy && virst net-start (as an example) which is not bad, but I prefer to use virsh net-update mechanism because it won't interrupt the guest's network.

Also, I found the diff in a way like provided below:

Info: Applying configuration version 'XXX_YYY'
--- /tmp/current20240208-2398021-tnw8xs 2024-02-08 15:00:34.873488194 +0000
+++ /tmp/desire20240208-2398021-xhp6ng  2024-02-08 15:00:34.873488194 +0000
@@ -5,8 +5,10 @@
   <virtualport type='openvswitch'/>
   <portgroup name='EXAMPLE_VLAN'>
     <vlan trunk='yes'>
+      <tag id='72'/>
       <tag id='114'/>
       <tag id='212'/>
+      <tag id='0' nativeMode='untagged'/>
     </vlan>
   </portgroup>
   <portgroup name='EXAMPLE_VLAN2'>
Notice: /**/content: false (corrective)

more human-readable and it provides an idea about what is different between the current state and the state in Puppet repo.

Thanks!

trefzer added a commit that referenced this pull request Mar 15, 2024
@trefzer trefzer merged commit 9b79032 into cirrax:master Mar 15, 2024
@trefzer
Copy link
Contributor

trefzer commented Mar 15, 2024

This looks good, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants