Human readable diff in case of changes and correct sort for portgroups #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, I would like to thank you for the module.
I found that the module may add false positive notice events/messages on a puppet agent side.
It is a reproducible case.
As an example I added one more portgroup for the network configuration via yaml and in parallel I added a new portgroup on the host via
virsh net-update
. Starting from that point I see notices every time I runpuppet agent
on a client.The false positives are gone as soon as I do
virsh net-destroy && virst net-start
(as an example) which is not bad, but I prefer to usevirsh net-update
mechanism because it won't interrupt the guest's network.Also, I found the diff in a way like provided below:
more human-readable and it provides an idea about what is different between the current state and the state in Puppet repo.
Thanks!