Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider vps configuration missing from default cirrus.yml provider settings #132

Closed
jkeifer opened this issue Apr 7, 2022 · 0 comments
Closed
Assignees
Labels
bug Something isn't working small
Milestone

Comments

@jkeifer
Copy link
Collaborator

jkeifer commented Apr 7, 2022

Somehow I missed that the VPC settings needed to be configured both in the provider block and in the custom batch block. Of course I think batch could reference the provider settings and we don't even need the batch one.

Regardless, this needs to be updated in the default template, and will be a breaking change for end users if we remove the batch settings expectation. Without it, lambda functions are not run within the specified VPC security group/subnets.

@jkeifer jkeifer added the bug Something isn't working label Apr 7, 2022
@jkeifer jkeifer added this to the 0.7.0 milestone Apr 7, 2022
@jkeifer jkeifer self-assigned this Apr 7, 2022
@jkeifer jkeifer added the small label May 25, 2022
@jkeifer jkeifer mentioned this issue Aug 29, 2022
@jkeifer jkeifer closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small
Projects
None yet
Development

No branches or pull requests

1 participant