Orcid update

[pradtke]

No description provided.

[pradtke]

@windhamg could you add a unit test for the email handling? I think cover these cases:

• no emails
• no primary email but an non-primary
• a primary and a non-primary
• only a primary

It's a pain to unit test the postFinalStep method due to the rest calls, so I'd recommend breaking out the logic about parsing the response to get an email into its own method that returns the email (or null), and then test that method by passing in different response arrays.

[windhamg]

@pradtke unit test has been added

@windhamg could you add a unit test for the email handling? I think cover these cases:

• no emails
• no primary email but an non-primary
• a primary and a non-primary
• only a primary

It's a pain to unit test the postFinalStep method due to the rest calls, so I'd recommend breaking out the logic about parsing the response to get an email into its own method that returns the email (or null), and then test that method by passing in different response arrays.