Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support PKCE #87

Merged
merged 3 commits into from
Nov 22, 2023
Merged

feat: support PKCE #87

merged 3 commits into from
Nov 22, 2023

Conversation

tft7000
Copy link

@tft7000 tft7000 commented Nov 10, 2023

Added support for PKCE (extracted from PR #86 and reduced to the minimum).

PKCE was implemented via the underlying library. For that I had to increase the minimum version for
league/oauth2-client to 2.7. I think this should be fine, as there seems not to be any dependency
differences between 2.6 and 2.7.

  • Test added
  • Documentation added; Note: README.md and CHANGELOG.md not updated
  • Tests pass
  • composer run validate passes

@pradtke pradtke self-assigned this Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de04151) 71.08% compared to head (23edf4a) 72.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     71.08%   72.35%   +1.26%     
- Complexity      186      194       +8     
============================================
  Files            14       14              
  Lines           588      615      +27     
============================================
+ Hits            418      445      +27     
  Misses          170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pradtke pradtke merged commit 6bd9610 into cirrusidentity:master Nov 22, 2023
6 checks passed
@pradtke
Copy link
Contributor

pradtke commented Nov 22, 2023

@tft7000 Thank you very much for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants