Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Sync api package with the new .proto #31

Merged
merged 1 commit into from Aug 6, 2020
Merged

Sync api package with the new .proto #31

merged 1 commit into from Aug 6, 2020

Conversation

edigaryev
Copy link
Contributor

Generated with:

go get -u google.golang.org/protobuf/cmd/protoc-gen-go
go get -u google.golang.org/grpc/cmd/protoc-gen-go-grpc
protoc --go_out=. --go-grpc_out=. --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative cirrus_ci_service.proto

Generated with:

go get -u google.golang.org/protobuf/cmd/protoc-gen-go
go get -u google.golang.org/grpc/cmd/protoc-gen-go-grpc
protoc --go_out=. --go-grpc_out=. --go_opt=paths=source_relative --go-grpc_opt=paths=source_relative cirrus_ci_service.proto
@fkorotkov
Copy link
Contributor

Interesting that there are two files now. I generated it via the following command from the root of cirrus-ci repo:

docker run -v `pwd`:/defs namely/protoc-all \
  -d services/cirrus-ci-rpc/api/src/main/proto \
  -o build/generated/proto/api \
  -l go

@edigaryev
Copy link
Contributor Author

Interesting that there are two files now.

I think this is due to docker-protoc's use of the plugins= option.

If you look at the official manual, there are actually two files generated that belong to the same package: https://grpc.io/docs/languages/go/quickstart/#regenerate-grpc-code

Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've updated the generate instructions.

@edigaryev edigaryev merged commit 08571a4 into master Aug 6, 2020
@fkorotkov fkorotkov deleted the sync-api branch August 6, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants