Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize .cirrus.yaml #689

Closed
AlexWayfer opened this issue Aug 4, 2020 · 4 comments
Closed

Recognize .cirrus.yaml #689

AlexWayfer opened this issue Aug 4, 2020 · 4 comments
Labels

Comments

@AlexWayfer
Copy link
Contributor

Description

Please, add support of .cirrus.yaml configuration files.

.yaml is recommended by YAML standard: https://yaml.org/faq.html

image

Context

I've created a repository with a .cirrus.yaml file and Cirrus CI integration and there is no Cirrus CI triggers.

AlexWayfer added a commit to AlexWayfer/alexwayfer.name that referenced this issue Aug 4, 2020
@fkorotkov
Copy link
Contributor

Seems like most of the CI do use *.yml. I think it's better to leave it as is for consistency. What do you think?

@AlexWayfer
Copy link
Contributor Author

What do you think?

YAML asks to use .yaml "when possible", as mentioned above.

If you think that it's possible — it's better to support the standard's recommendations, I think. Like .cirrus.y{a,}ml glob.

If it's hard for you, like for RuboCop, you can close it.

But it's weird when you have *.yaml and *.yml files in your project. And I think we should stick to recommendations of the format. And allow variations when it's possible. Yes, .yml is very popular, unfortunately, but if we can (in a some project) support both of extensions — I think we should to.

@fkorotkov
Copy link
Contributor

This should work now

@AlexWayfer
Copy link
Contributor Author

This should work now

I finally confirm, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants