Cache support #17
Merged
Cache support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation attempts to support parallel CLI executions and has no automatic cleaning for now.
This ensures that we will also create OS-dependent cache directory if it doesn't exist yet.
Pass everything to Cirrus CI annotations.
fkorotkov
reviewed
Aug 3, 2020
| ) | ||
|
|
||
| type PutOperation struct { | ||
| tmpBlobFile *os.File |
There was a problem hiding this comment.
let's use a buffered writer here
fkorotkov
reviewed
Aug 3, 2020
internal/executor/cache/cache.go
Outdated
| } | ||
|
|
||
| func (c *Cache) blobPath(key string) string { | ||
| // Sanitize user-controlled data by hashing it |
There was a problem hiding this comment.
Might not be necessary since cache keys are always in this form <cache name>-<sha256>. Plus will be easier for users to find the blobs for manual inspection.
There was a problem hiding this comment.
It's technically possible for the arbitrary code that runs in the task's environment to impersonate the agent and connect to the CLI over new (or existing) RPC connection.
So this depends on whether we trust that environment or not.
There was a problem hiding this comment.
Alternatively, we can validate the key using a simple regular expression.
There was a problem hiding this comment.
Yeah, can do something like:
Suggested change
| // Sanitize user-controlled data by hashing it | |
| isSafeChar := func(c rune) bool { | |
| if '0' <= c && c <= '9' { return true } | |
| if 'a' <= c && c <= 'z' { return true } | |
| if 'A' <= c && c <= 'Z' { return true } | |
| if c == '-' || c == '_' { return true } | |
| return false | |
| } | |
| isNotSafeChar := func(c rune) bool { | |
| return !isSafeChar(c) | |
| } | |
| containsNonSafeChar := strings.IndexFunc(key, isNotSafeChar) >= 0 | |
| if !containsNonSafeChar { | |
| // only safe characters so no need for a sanitization | |
| return key | |
| } | |
| // Sanitize user-controlled data by hashing it |
fkorotkov
reviewed
Aug 3, 2020
fkorotkov
reviewed
Aug 3, 2020
fkorotkov
reviewed
Aug 3, 2020
Co-authored-by: Fedor Korotkov <fedor.korotkov@gmail.com>
2020/08/03 13:14:37 Failed to download test-e7c76decfad1e83298b9a9ddf7f2f37ad42da790a1d665b6a2404c3c82b66e48 cache! rpc error: code = ResourceExhausted desc = grpc: received message larger than max (10485765 vs. 4194304)
fkorotkov
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation attempts to support parallel CLI executions and has no automatic cleaning for now.