-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-house parser #58
In-house parser #58
Conversation
@fkorotkov's there are a few files that are technically still under MIT since I've taken them directly from keanu:
Do you consent to re-license the code in these files under MPL-2.0, so I can remove these lines? |
I consent but with MIT I don't think you even need to ask 😅 |
Implemented in 2beda35. However, since some changes to the Gval package are still waiting to be upstreamed (PaesslerAG/gval#38), |
I think replacing the RPC parser with the local one right away seem like a bit too bold. What do you think about having a |
Resolves #16.
We can now switch to the official repository since all the required changes have been upstreamed, see PaesslerAG/gval#38.
Some things that still clearly need to be done:
only_if
(this is currently the reason why the test suite fails)Resolves #16.