-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources support #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should we document the resource capabilities? In the OpenAPI? In v1.go
? Somewhere in the docs?
internal/worker/worker.go
Outdated
@@ -116,6 +116,9 @@ func (worker *Worker) registerWorker(ctx context.Context) error { | |||
Meta: v1.Meta{ | |||
Name: worker.name, | |||
}, | |||
Resources: map[string]uint64{ | |||
v1.ResourceTartVMs: 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make a VM specify this default resource as 1. So scheduling will be working appropriately by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make a VM specify this default resource as 1. So scheduling will be working appropriately by default.
Implemented in 456c713.
Documented in |
Things that are still left to be implemented:
ability to pass resources via the CLI→ d7d06fc + ab6f206Resolves #47.