Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document http_directory #75

Closed
HariSekhon opened this issue Jun 13, 2023 · 5 comments · Fixed by #77
Closed

Document http_directory #75

HariSekhon opened this issue Jun 13, 2023 · 5 comments · Fixed by #77
Assignees

Comments

@HariSekhon
Copy link

It seems there is a new http_directory setting but it's not documented anywhere that I can find.

When I add it I find that I get this output:

==> ubuntu-22.04.tart-cli.ubuntu: Starting HTTP server on port 8232

so it seems to work on the latest plugin, I basically guessed this from issues #29, #58, #63.

@HariSekhon
Copy link
Author

HariSekhon commented Jun 22, 2023

@edigaryev I can't see where the http_directory setting is documented, I can't see it here:

https://github.com/cirruslabs/packer-plugin-tart/blob/main/README.md#configuration

or here:

https://developer.hashicorp.com/packer/plugins/builders/tart

@edigaryev
Copy link
Contributor

https://developer.hashicorp.com/packer/plugins/builders/tart

It should be only here due to @include usage.

I guess we have to wait some time until the HashiCorp's website pulls the new version.

@edigaryev
Copy link
Contributor

@HariSekhon
Copy link
Author

@edigaryev Thanks - there is a slight formatting bug showing the backticks here:

`wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg`

Would it be possible to include an example usage as I believe this will be the common case if you look at how the other builders are used.

@edigaryev
Copy link
Contributor

edigaryev commented Jun 26, 2023

there is a slight formatting bug showing the backticks here

Good catch, I've created hashicorp/packer-plugin-sdk#191 to address this.

Would it be possible to include an example usage as I believe this will be the common case if you look at how the other builders are used.

Can you provide concrete scenarios that you would like to be documented as examples?

Creating a separate ticket for this would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants