Check all VMs for MAC collision

[fkorotkov]

Before only suspendable VMs were getting checked. Not sure why. It makes sense to check all.

[edigaryev]

Before only suspendable VMs were getting checked. Not sure why.

Because for the rest of the VMs we do this in tart clone:

tart/Sources/tart/Commands/Clone.swift

Lines 65 to 67 in 9f38441

	let generateMAC = try localStorage.hasVMsWithMACAddress(macAddress: sourceVM.macAddress())
	&& sourceVM.state() != .Suspended
	try sourceVM.clone(to: tmpVMDir, generateMAC: generateMAC)

[fkorotkov]

There was a report when a person just scped the same VM twice. 🤷 Seems like an improvement.

[edigaryev]

There was a report when a person just scped the same VM twice. 🤷 Seems like an improvement.

Let's acquire the global lock unconditionally then to simplify things up.

[fkorotkov]

SGTM. PTAL 2af05de