Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git based deployment versioning and other deploy.sh improvements #112

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

mreeve-snl
Copy link
Collaborator

@mreeve-snl mreeve-snl commented Dec 15, 2023

πŸ—£ Description

  • Adds git control into LME's version process

    • testing variable: FORCE_LATEST_VERSION, can be set so a specific version can be passed in the environment during testing:
      • TO TEST upgrading:
      export FORCE_LATEST_VERSION="1.2.0"
      sudo -E ./deploy.sh install
      sudo -E ./deploy.sh upgrade
      
      • To Test Clean Install:
      export FORCE_LATEST_VERSION="1.3.0"
      sudo -E ./deploy.sh install
      
    • checkout LME directory to latest version
  • fixes "bug" in deploy.sh:

    • makes it so that the permissions of Chapter\ 3\ Files directory are preseserved!
  • upgrade function with 1.2.0 -> 1.3.0, upgrade path

  • adds various features to deploy.sh:

    • makes logging wrappers
    • better prompt on install
    • ready check, to confirm user is ok with an action before proceeding
    • Checks for required packages during run of deploy.sh. SHould help if we ever add a package later to the deployment script

πŸ’­ Motivation and context

LME versioning should be tracked automatically via git and the installed version should be automatically tracked via git.
There was a little QOL of changes need for deploy.sh as well.

Solves: #69

πŸ§ͺ Testing

Tested on a clean install of 1.2.0 -> upgrade 1.3.0
tested on a clean install of 1.3.0 on this branch

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mreeve-snl
Copy link
Collaborator Author

I'll comment here when this is ready

@mreeve-snl mreeve-snl changed the base branch from main to release-1.3.0 December 15, 2023 21:36
@mreeve-snl mreeve-snl changed the title Mreeve 69 git based deployment versioning git based deployment versioning Dec 16, 2023
@mreeve-snl
Copy link
Collaborator Author

When we're testing this, we'll want to use the following command:

export FORCE_LATEST_VERSION=1.3.0

that way the version set in lme.conf will be appropriate and expected.

@mreeve-snl mreeve-snl changed the title git based deployment versioning git based deployment versioning and updating Dec 16, 2023
@mreeve-snl mreeve-snl changed the title git based deployment versioning and updating git based deployment versioning and updating dashboards Dec 16, 2023
@mreeve-snl mreeve-snl changed the title git based deployment versioning and updating dashboards git based deployment versioning and other deploy.sh improvements Dec 16, 2023
cbaxley
cbaxley previously approved these changes Dec 18, 2023
@mreeve-snl
Copy link
Collaborator Author

OK release is ready for testing/approval!

@mitchelbaker-cisa mitchelbaker-cisa force-pushed the mreeve-69-git_based_deployment_versioning branch from 9beac38 to 28cfe81 Compare December 18, 2023 23:45
Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded to latest version and ran clean install.

@mreeve-snl mreeve-snl merged commit 76d1852 into release-1.3.0 Dec 19, 2023
3 checks passed
@mreeve-snl mreeve-snl deleted the mreeve-69-git_based_deployment_versioning branch December 19, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants