Malcolm v23.09.0 #279
Merged
Malcolm v23.09.0 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not where Arkime's log files are going. addresses idaholab#243 Signed-off-by: Seth Grover <mero.mero.guero@gmail.com>
…ng defaults) to decrease complexity
…es to reduce configuration complexity
…support viewerOnly fields
…a environment variable
…a environment variable
…template, we need to make sure everything that should be in there is. So this commit is a copy/paste of the template from Arkime's db.pl into dashboards/templates/composable/component/arkime.json
…COMPOSE_FILE and MALCOLM_CONFIG_DIR environment variables, respectively, for the control.py scripts
…d' from the Notice, Alert and Signature table and filtered out Suricata's Generic Protocol Command Decode
…lates have been created, to avoid conflicts of fields auto-created before the templates are ready
…aked various other dockerfiles to avoid __pycache__ directories. Signed-off-by: Seth Grover <mero.mero.guero@gmail.com>
…into v23.09.0_merge_cisagov
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -341,8 +346,10 @@ | |||
|
|
|||
| # extract runtime files | |||
| if installPath and os.path.isdir(installPath): | |||
| MalcolmPath = installPath | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
| if 'JOBRESULT_RETENTION' in environ: | ||
| JOBRESULT_RETENTION = _environ_get_and_map('JOBRESULT_RETENTION', None, _AS_INT) | ||
| if 'JOB_RETENTION' in environ: | ||
| JOB_RETENTION = _environ_get_and_map('JOB_RETENTION', None, _AS_INT) |
Check notice
Code scanning / CodeQL
Unused global variable Note
| JOB_RETENTION = _environ_get_and_map('JOB_RETENTION', None, _AS_INT) | ||
| # JOBRESULT_RETENTION was renamed to JOB_RETENTION in the v3.5.0 release of NetBox. For backwards compatibility, map JOBRESULT_RETENTION to JOB_RETENTION | ||
| elif 'JOBRESULT_RETENTION' in environ: | ||
| JOB_RETENTION = _environ_get_and_map('JOBRESULT_RETENTION', None, _AS_INT) |
Check notice
Code scanning / CodeQL
Unused global variable Note
| htpasswdLines = list() | ||
| with open(htpasswdFile, 'r') as f: | ||
| htpasswdLines = f.readlines() | ||
| with open(htpasswdFile, 'w') as f: | ||
| if args.cmdAuthSetupNonInteractive and username and args.authPasswordHtpasswd: | ||
| f.write(f'{username}:{args.authPasswordHtpasswd}') |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information High
…into v23.09.0_merge_cisagov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Malcolm v23.09.0 is a release containing enhancements and bug fixes.
v23.08.1...v23.09.0