Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Persist Left Panel Resize #108

Merged
merged 8 commits into from
Mar 29, 2023
Merged

Persist Left Panel Resize #108

merged 8 commits into from
Mar 29, 2023

Conversation

arniebradfo
Copy link
Collaborator

Description

Give the text content in the left panel more room for readability.

  • Left Panel is now a bit larger by default - 600px
  • Left Panel now persists its resize between page reloads using window.localStorage
  • The drag resize now more precise
  • css grid layout is simplified
  • Double clicking the dragger will reset the left panel to the default size
  • I made a commit that persists the collapsed state of either panel, but the graph does not initialize properly if the panel its in starts collapsed. I reverted that change and left a note.

Testing

  • drag resize the left panel
  • reload the page

Screenshots

Screen Shot 2023-03-26 at 6 55 22 PM

@sang2925
Copy link
Collaborator

@arniebradfo I found a bug where if we refresh the page after resizing the left panel, the command log output disappears.

Copy link
Collaborator

@sang2925 sang2925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2023-03-27.at.2.18.54.PM.mov

edit: it happens in develop too, so I will create a bug for it and change pr to approved.

@sang2925 sang2925 merged commit 39d2905 into develop Mar 29, 2023
@sang2925 sang2925 deleted the persist-left-panel-resize branch March 29, 2023 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants