This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Navigation Target Styles #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f513314.
arniebradfo
commented
Mar 29, 2023
Comment on lines
+34
to
42
| scrollTargetIndex: -1, | ||
| scrollToCommand(commandId: string, commandIds: string[], behavior: ScrollBehavior = 'smooth') { | ||
| const commandIndex = commandIds.findIndex((id) => commandId === id); | ||
| this.scrollTargetIndex = commandIndex; | ||
| if (commandIndex > -1) { | ||
| listRef?.current?.scrollToIndex({ index: commandIndex, align: 'start', behavior }); | ||
| setTimeout(() => (this.scrollTargetIndex = -1), UtilityStyles.SCROLL_TARGET_DURATION + 500); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Setting and then removing the scrollTargetIndex based on the scrollToCommand method seems like the best solution to style the item only when scrolling to it.
sharplessHQ
approved these changes
Mar 29, 2023
sang2925
approved these changes
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When navigating to a row of a scrolling list (like a command), we want to apply some kind of visual indicator of the target. This is traditionally styled with the
:targetpseudo selector when navigating to an internal anchor link. We are implementing it differently but the concept is the sameUtilityStyle.scrollTargetUtilityStyle.scrollTargeton:InfoRows -scrollTargetis added and then removed by thescrollToCommandmethodInfoRows generally via thescrollTargetpropTODOs
Testing
Screenshots