Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

closes User setting displaying incorrect data #21

Merged

Conversation

MarkisK
Copy link

@MarkisK MarkisK commented Oct 20, 2022

πŸ—£ Description

πŸ’­ Motivation and context

User setting text is in dot notation

πŸ§ͺ Testing

View #18 for testing steps
Check that the User Setting user.name is now Username

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Add a tag or create a release.

@MarkisK MarkisK changed the title closes User setting displaying incorrect data #18 closes User setting displaying incorrect data Oct 20, 2022
@GoldingAustin
Copy link
Collaborator

@MarkisK Can you please revert the last commit you made adding your own projectId? That value is a secret set when the E2E workflow runs and it is not required to run the tests locally.

We're looking into why the E2E tests are not running in the workflow now

@MarkisK
Copy link
Author

MarkisK commented Oct 20, 2022

@GoldingAustin I thought so as well. I will revert

@GoldingAustin
Copy link
Collaborator

Thank you, and thanks for the excellent PR! Because everything builds and this is a small change, I'm going to skip the Cypress tests and merge. Thank you for contributing :)

@GoldingAustin GoldingAustin merged commit 9d91091 into cisagov:develop Oct 20, 2022
@MarkisK MarkisK deleted the bugfix/update-usersetting-wording branch October 21, 2022 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants