Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Blueprint Package Updates + Dialog UI changes #87

Merged
merged 22 commits into from
Mar 8, 2023

Conversation

arniebradfo
Copy link
Collaborator

Description

Updated the @blueprint and blueprint-styler packages to their latest versions, and updated several UI elements related to Dialog

Changes

  • Updated the @blueprint and blueprint-styler packages to their latest versions
  • Updated all usages of deprecated blueprint components: MenuItem, Suggest, Select, MultiSelect, Popover, are all now the '2' version.
  • Added DialogEx, DialogBodyEx, and DialogFooterEx components to extend the functionality of the new Blueprint DialogBody & DialogFooter components
    • update style of DialogEx to fit the 'Carbon' Style with the large cancel/confirm buttons at the bottom, see screenshots
    • Updated the all Dialogs to use the new DialogEx
  • Made several other UI updates

Testing

  • Dialogs visual appearance
    • do they look normal?
    • do they fall off the page or become un-scrollable?
  • any issues to do with 'Dropdown' components: Suggest, Select, MultiSelect

Screenshots

... coming

@arniebradfo arniebradfo requested review from GoldingAustin, sharplessHQ and sang2925 and removed request for GoldingAustin March 1, 2023 22:27
@sang2925
Copy link
Collaborator

sang2925 commented Mar 7, 2023

@arniebradfo

Just verifying that the text for the buttons (Cancel/Import) are aligned correctly.
Screenshot 2023-03-06 at 2 55 00 PM

@GoldingAustin GoldingAustin merged commit 83e3fc4 into develop Mar 8, 2023
@GoldingAustin GoldingAustin deleted the blueprint-package-updates-2 branch March 8, 2023 01:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants