Add EXO rationales #447

adhilto · 2023-07-19T17:57:16Z

🗣 Description

Adds the rationales to the EXO baseline.

💭 Motivation and context

Closes #434.

🧪 Testing

Copied the rationales into Word to catch obvious typos.

✅ Pre-approval checklist

This PR has an informative and human-readable title.
Changes are limited to a single goal - eschew scope creep!
All future TODOs are captured in issues, which are referenced
in code comments.
All relevant type-of-change labels have been added.
These code changes follow cisagov code standards.
All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
Tests have been added and/or modified to cover the changes in this PR.
All new and existing tests pass.

✅ Pre-merge checklist

Revert dependencies to default branches.
Finalize version.

✅ Post-merge checklist

Create a release.

schrolla

Lots of comments to work existing rationales into the example two sentence structure that explains the risk, followed by the mitigation. Otherwise, just minor wording suggestions and changes.

baselines/exo.md

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

schrolla

Small number of recommended updates that are really fixes for my previous suggestions where it caused a grammar error or I reconsidered/revised the wording for brevity and clarity.

baselines/exo.md

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

buidav

Minor formatting things

baselines/exo.md

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

adhilto · 2023-07-25T19:19:59Z

@nanda-katikaneni Looks like we've got two approvals, we should be good to go.

* Added rationales to groups 1-3 * DMARC rationale * SMTP AUTH rationale * contact sharing rationale * 7.1 rationale * DLP rationale * common attachment filter rationale * 10 rationales * 11 rationales * 12 rationale * 13 rationale * 14 rationale * 15 rationale * 16 rationale * 17 rationale * Minor typo corrections * Remove reference to MITRE attack * Update SPF rationale part 1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update DKIM rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update DMARC rationale part 1 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update DMAR rationale part 2 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update alert rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update alert rationale part 2 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update audit rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update log retention rational Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update premium audit rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update SPF rationale part 2 Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * SMTP AUTH may rationale update Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update SMPT auth rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update contact sharing rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update contact sharing rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update external sender rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update dlp rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update common attachments filter rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update file type detection rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update file types rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update phishing rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Remove hyphen Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update ai tool rationalte Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update allow list rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update safe list rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update mailbox audit rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update spam rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update spam junk folder rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update spam allowlist rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update deny list rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update url blocking rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update url file scanning rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Update click tracking rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Remove space Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Remove unneeded"to" Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Remove line breaks Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Minor typo fixes Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Tweaked wording for anti spam rationale Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> * Added security perspective to spam rationale * Added security perspective to spam quarantining rationale * Added missing space Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com> * Removed whitespace Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com> * Removed whitespace Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com> * Removed whitespace Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com> * Removed whitespace Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com> --------- Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com> Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

adhilto added the baseline-document Issues relating to the text in the baseline documents themselves label Jul 19, 2023

adhilto added this to the Emerald milestone Jul 19, 2023

adhilto requested review from buidav and schrolla July 19, 2023 17:57

adhilto self-assigned this Jul 19, 2023

adhilto linked an issue Jul 19, 2023 that may be closed by this pull request

Add rationale to the EXO baseline #434

Closed

2 tasks

buidav changed the base branch from main to emerald July 19, 2023 18:57

buidav mentioned this pull request Jul 20, 2023

Address EXO comment and structural changes in the baseline document #436

Merged

5 tasks

adhilto added 17 commits July 21, 2023 16:16

Added rationales to groups 1-3

e5f3db9

DMARC rationale

e574d58

SMTP AUTH rationale

1fc26bb

contact sharing rationale

e99a634

7.1 rationale

8c948b4

DLP rationale

a2065c7

common attachment filter rationale

efb6688

10 rationales

989e977

11 rationales

3c6b9d8

12 rationale

0f0a09b

13 rationale

866c4ca

14 rationale

42aca0d

15 rationale

8ce9b79

16 rationale

7596b6c

17 rationale

1517690

Minor typo corrections

bf91e43

Remove reference to MITRE attack

6838af4

adhilto force-pushed the 434-exo-rationale branch from ef90e3b to 6838af4 Compare July 21, 2023 16:16

schrolla requested changes Jul 24, 2023

View reviewed changes

adhilto and others added 3 commits July 24, 2023 17:04

Update SPF rationale part 1

0e1e1a1

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Update DKIM rationale

c74b5b4

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Update DMARC rationale part 1

fd98838

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

adhilto and others added 5 commits July 25, 2023 09:22

Update spam allowlist rationale

15775e3

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Update deny list rationale

5410808

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Update url blocking rationale

1c43259

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Update url file scanning rationale

423b6a2

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Update click tracking rationale

1ed2035

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

schrolla requested changes Jul 25, 2023

View reviewed changes

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

adhilto and others added 5 commits July 25, 2023 09:43

Remove space

edd5517

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Remove unneeded"to"

8ba6208

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Remove line breaks

4a8bd2e

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Minor typo fixes

448ba71

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

Tweaked wording for anti spam rationale

6585ba0

Co-authored-by: Addam Schroll <108814318+schrolla@users.noreply.github.com>

schrolla approved these changes Jul 25, 2023

View reviewed changes

adhilto added 2 commits July 25, 2023 10:56

Added security perspective to spam rationale

18461c4

Added security perspective to spam quarantining rationale

47f943e

buidav requested changes Jul 25, 2023

View reviewed changes

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

baselines/exo.md Outdated Show resolved Hide resolved

adhilto and others added 5 commits July 25, 2023 11:25

Added missing space

ddd2c80

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

Removed whitespace

4c130e7

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

Removed whitespace

0d02f83

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

Removed whitespace

1451aec

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

Removed whitespace

2cd33b8

Co-authored-by: David Bui <105074908+buidav@users.noreply.github.com>

adhilto requested a review from buidav July 25, 2023 18:27

buidav approved these changes Jul 25, 2023

View reviewed changes

nanda-katikaneni merged commit c622522 into emerald Jul 25, 2023
1 of 4 checks passed

buidav mentioned this pull request Jul 25, 2023

Add rationale to the EXO baseline #434

Closed

2 tasks

adhilto deleted the 434-exo-rationale branch July 25, 2023 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EXO rationales #447

Add EXO rationales #447

adhilto commented Jul 19, 2023

schrolla left a comment

schrolla left a comment

buidav left a comment

adhilto commented Jul 25, 2023

Add EXO rationales #447

Add EXO rationales #447

Conversation

adhilto commented Jul 19, 2023

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

✅ Pre-merge checklist

✅ Post-merge checklist

schrolla left a comment

Choose a reason for hiding this comment

schrolla left a comment

Choose a reason for hiding this comment

buidav left a comment

Choose a reason for hiding this comment

adhilto commented Jul 25, 2023