Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ScubaGoggles and baseline versions from v0.1 to v0.2 #303

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

buidav
Copy link
Collaborator

@buidav buidav commented Jun 5, 2024

πŸ—£ Description

  • Version bumps ScubaGoggles and the SCBs to v0.2

πŸ’­ Motivation and context

Closes #280
Closes #281

πŸ§ͺ Testing

  • Run ScubaGoggles via script and install for all products.
  • Review HTML reports, documentation and baselines to see if the versioning was properly done.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

βœ… Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@buidav buidav added the version bump This issue or pull request increments the version number label Jun 5, 2024
@buidav buidav added this to the Barracuda milestone Jun 5, 2024
@buidav buidav self-assigned this Jun 5, 2024
@buidav buidav linked an issue Jun 5, 2024 that may be closed by this pull request
1 task
@buidav buidav changed the title Bump ScubaGoggles and basline versions from v0.1 to v0.2 Bump ScubaGoggles and baseline versions from v0.1 to v0.2 Jun 5, 2024
Copy link
Collaborator

@snarve snarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@LaurenBassett LaurenBassett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@LaurenBassett LaurenBassett self-requested a review June 5, 2024 20:30
@buidav buidav merged commit 00cf550 into main Jun 5, 2024
10 checks passed
@buidav buidav deleted the 280-bump-scubagoggles-from-v01-to-v02 branch June 5, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump SCuBA Baseline SCB versioning from 0.1 to 0.2 Bump ScubaGoggles from v0.1 to v0.2
4 participants