Skip to content

Commit

Permalink
Clarify that a version bump should only be done when appropriate
Browse files Browse the repository at this point in the history
Changes to internal dependencies that do not change the API (or the
build product) do not require and should not receive a version bump.

Co-authored-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com>
  • Loading branch information
jsf9k and mcdonnnj committed Mar 8, 2023
1 parent 8d6fa98 commit 3364e18
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
7 changes: 5 additions & 2 deletions src/lineage/templates/clean_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ your project.
- Remove any of the following that do not apply.
- These boxes should remain unchecked until the pull request has been approved.

- [ ] Bump version via the `bump_version.sh` script, if this
repository is versioned.
- [ ] Bump major, minor, patch, or pre-release version [as
appropriate](https://semver.org/#semantic-versioning-specification-semver)
via the `bump_version.sh` script *if* this repository is
versioned *and* the changes in this PR [warrant a version
bump](https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api).

## ✅ Post-merge checklist ##

Expand Down
7 changes: 5 additions & 2 deletions src/lineage/templates/conflict_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,11 @@ that you must resolve before merging this pull request!
- Remove any of the following that do not apply.
- These boxes should remain unchecked until the pull request has been approved.

- [ ] Bump version via the `bump_version.sh` script, if this
repository is versioned.
- [ ] Bump major, minor, patch, or pre-release version [as
appropriate](https://semver.org/#semantic-versioning-specification-semver)
via the `bump_version.sh` script *if* this repository is
versioned *and* the changes in this PR [warrant a version
bump](https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api).

## ✅ Post-merge checklist ##

Expand Down

0 comments on commit 3364e18

Please sign in to comment.