Gracefully Handle Missing Permissions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav3r
reviewed
Aug 27, 2020
jsf9k
reviewed
Aug 27, 2020
| netloc=f"{username}:{password}@{parts.netloc}" | ||
| ).geturl() | ||
| logging.info("Assigning credentials for push.") | ||
| run([GIT, "remote", "set-url", "origin", cred_url], cwd=repo.full_name) |
There was a problem hiding this comment.
At some point we should replace these git commands with GitPython.
There was a problem hiding this comment.
@felddy Do you remember why you didn't leverage that when you first wrote this?
There was a problem hiding this comment.
Probably didn't know about it yet. Not a technical reason.
jsf9k
requested changes
Aug 27, 2020
felddy
approved these changes
Aug 27, 2020
src/lineage/entrypoint.py
Outdated
| body = pystache.render(clean_template, template_data) | ||
| create_pull_request( | ||
| repo, pr_branch_name, local_branch, title, body, draft=False | ||
| logging.info( |
There was a problem hiding this comment.
Let's make it a warning, but make sure the warning string starts with "ERROR!'
src/lineage/entrypoint.py
Outdated
| create_pull_request( | ||
| repo, pr_branch_name, local_branch, title, body, draft=False | ||
| logging.info( | ||
| "Not creating a new pull request since the branch already existed." | ||
| ) | ||
| else: | ||
| logging.info( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds functionality to gracefully handle a previously fatal case of missing permissions. This should resolve #4 . It also adds a status badge to the README for the
lineage_scanworkflow.💭 Motivation and Context
We have run into the issue where a repository does not have the correct permissions configured, and this causes the Lineage workflow to fail. If unnoticed, it can go on for an extended period of time (the latest was four weeks). When this happens, the workflow will only process repositories until it hits the problem repository. Anything in the search results after that will not be updated.
The new badge allows an at-a-glance check for the last
lineage_scanworkflow run.🧪 Testing
Automated tests pass.
🚥 Types of Changes
✅ Checklist