Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conflict Resolution Directions #31

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Aug 4, 2021

🗣 Description

This PR updates the conflict resolution instructions to remove the directions to ignore changes to the Lineage configuration file.

💭 Motivation and context

All Lineage generated changes should be manually reviewed to ensure that desired changes are being made.

🧪 Testing

Automated tests pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

During a Lineage merge any changes should be manually resolved to ensure that
all relevant changes are being applied. The current directions may lead someone
to blindly ignore changes in the Lineage configuration file. Since this file is
rarely changed it should always be manually reviewed if it's a file with
conflicts.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Aug 4, 2021
@mcdonnnj mcdonnnj self-assigned this Aug 4, 2021
@mcdonnnj mcdonnnj added this to In progress in Skeleton Maintenance via automation Aug 4, 2021
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! 🎸

Skeleton Maintenance automation moved this from In progress to Reviewer approved Aug 5, 2021
@mcdonnnj mcdonnnj merged commit a874684 into develop Aug 5, 2021
Skeleton Maintenance automation moved this from Reviewer approved to Done Aug 5, 2021
@mcdonnnj mcdonnnj deleted the improvement/amend_resolution_instructions branch August 5, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants