Safely Access Dictionary Key in Logging Output #35
+1
β1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π£ Description
This changes a dictionary access to use the
get()
method so a default value is returned if the key is missing.π Motivation and context
GitHub Actions runs for the
lineage_scan
workflow are currently failing because cisagov/con-pca-api is missing theversion
field in its.github/lineage.yml
file and we do not safely access that key in the parsed configuration dictionary. This can be seen at this point in the log. Although that repository needs to be fixed, it should not result in a failing state for this Action.π§ͺ Testing
Automated tests pass.
β Checklist