Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Library for GitHub Actions Functionality and Allow Manual lineage_scan Runs #37

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR makes two changes:

  • Adds the yanglbme/actions-toolkit library to provide an interface for GitHub Actions functionality.
  • Adds workflow_dispatch functionality to the lineage_scan workflow so it can be manually triggered.

💭 Motivation and context

The yanglbme/actions-toolkit library provides a Python implementation of the GitHub maintained actions/toolkit JavaScript project. Currently it only has the actions.core package implemented, but this is also the functionality we are most interested in using. While we are only using the functionality to get Action inputs right now, I have plans to leverage more of the GitHub Actions functionality available and this library will provide a clean means to do so.

Adding a workflow_dispatch trigger to the lineage_scan workflow allows us to manually trigger a run either in the GitHub web UI or by using the GitHub CLI. This will provide some flexibility when a skeleton has a number of PRs to merge and tests take a notable amount of time to manually trigger the workflow if a scheduled run has processed mid-merges.

🧪 Testing

Automated tests pass. A manually triggered lineage_scan run was successful.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

Switch to getting inputs for the Action using the actions-toolkit library.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 12, 2021
@mcdonnnj mcdonnnj self-assigned this Oct 12, 2021
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement - the future is bright! 😎

@mcdonnnj mcdonnnj merged commit 8dc9621 into develop Oct 12, 2021
@mcdonnnj mcdonnnj deleted the improvement/use_library_for_gha branch October 12, 2021 16:31
@mcdonnnj mcdonnnj added the hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants