Add a Warning Annotation to GitHub Actions Logs #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if a Pull Request exists in a repository that already has a Lineage branch on the remote. If a PR does not exist emit a warning as this is undesirable behavior. This may indicate an undeleted head branch from a previously merged Lineage PR.
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Oct 29, 2021
dav3r
approved these changes
Oct 29, 2021
jsf9k
requested changes
Oct 29, 2021
Reword to better describe the code that follows. Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds a warning annotation to the GitHub Actions logs if a repository already has a cisagov/action-lineage branch but there is no accompanying Pull Request.
💭 Motivation and context
@jsf9k Noticed a repository that did not get a new Lineage PR as expected in our latest round of krakening. Upon investigation I realized that a
lineage/skeletonbranch existed and was being updated, but there was no PR attached to it for review. I thought it would be good to add this check into Lineage itself to make it easier to notice this kind of problem in the future.🧪 Testing
Automated tests pass. Please see this Actions run for an example run.
✅ Checklist