Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Warning Annotation to GitHub Actions Logs #41

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

mcdonnnj
Copy link
Member

πŸ—£ Description

This PR adds a warning annotation to the GitHub Actions logs if a repository already has a cisagov/action-lineage branch but there is no accompanying Pull Request.

πŸ’­ Motivation and context

@jsf9k Noticed a repository that did not get a new Lineage PR as expected in our latest round of krakening. Upon investigation I realized that a lineage/skeleton branch existed and was being updated, but there was no PR attached to it for review. I thought it would be good to add this check into Lineage itself to make it easier to notice this kind of problem in the future.

πŸ§ͺ Testing

Automated tests pass. Please see this Actions run for an example run.

βœ… Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Check if a Pull Request exists in a repository that already has a Lineage
branch on the remote. If a PR does not exist emit a warning as this is
undesirable behavior. This may indicate an undeleted head branch from a
previously merged Lineage PR.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 29, 2021
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner October 29, 2021 15:10
@mcdonnnj mcdonnnj self-assigned this Oct 29, 2021
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one minor tweak to a comment; otherwise, this looks great!

src/lineage/entrypoint.py Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart thinking! ⚠️
Please note my one small suggestion.

src/lineage/entrypoint.py Outdated Show resolved Hide resolved
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my one comment language tweak.

src/lineage/entrypoint.py Outdated Show resolved Hide resolved
mcdonnnj and others added 2 commits October 29, 2021 12:14
Reword to better describe the code that follows.

Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
@mcdonnnj mcdonnnj requested a review from jsf9k October 29, 2021 17:00
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mcdonnnj mcdonnnj merged commit af14e4d into develop Oct 29, 2021
@mcdonnnj mcdonnnj deleted the improvement/add_branch_but_no_pr_warning branch October 29, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants