Update failing Dockerfile configuration #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition add the `--no-cache` option for apk to follow Dockerfile best practices.
We need to pin to the latest minor version of Python that we are testing this package against. This should be updated once a new version of Python is released and we have verified functionality with that version.
Add a RUN command to install the latest versions of pip, setuptools, and wheel before installing the contents of requirements.txt. Ensure that all pip commands use the `--no-cache-dir` option to keep with Dockerfile best practices.
mcdonnnj
added
bug
Update to correctly use the full form of CISA and add myself as an author.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the Docker configuration used to run this Python project as a GitHub Action. It includes:
💭 Motivation and context
The main cause of this update is because the
lineage_scanworkflow is in a state of failure because the Docker image for this project is unable to build. The root cause is a lack of build tools for the cffi Python package. While updating to resolve that I decided to do some other housekeeping to hopefully prevent unexpected failures of this nature in the future.🧪 Testing
Automated tests pass. A
lineage_scanrun with this branch was successful.✅ Pre-approval checklist