Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR fixes an issue with signal handling within interactive shells of child processes. Specifically,
pressing
control-c
in a shell causesawssh
to exit instead of allowing the shell to interpret the signal.💭 Motivation and context
Currently,
control-c
will exitawssh
which ends a user's remote session.This is broken and infuriating. By setting an ignore action on the interrupt signal, in the parent,
before the
subprocess
call, the child can then handle the signal as expected.The signal's action in the parent is restored after the child exits for good measure.
🧪 Testing
Tested on my local machine by connecting to various AWS instances and furiously mashing
control-c
.Tested with standard suite of continuous integration actions.
✅ Pre-approval checklist
✅ Post-merge checklist