Simplify output format #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove f-strings from logging statements and replace dict() with {}.
dav3r
added
the
improvement
jsf9k
reviewed
Dec 9, 2021
mcdonnnj
approved these changes
Dec 9, 2021
Co-Authored-By: Nick M. <mcdonnnj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR simplifies the format of the output CSV so that it only shows the fields that we currently care about.
While I was here, I updated a couple of things to make
pylinta little bit less angry (see f537891).💭 Motivation and context
The old output format is no longer needed. The new format is all that is now required. Out with the old, in with the new.
🧪 Testing
I executed the script and verified that the output looks as expected.
✅ Checklist