Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

feature: cpd-741 add total emails sent and clicked to overview #327

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

itsmostafa
Copy link
Contributor

add aggregate level stats: total emails sent and total emails clicked

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

tested locally

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

Copy link
Contributor

@dylanj1752 dylanj1752 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmostafa
Copy link
Contributor Author

hey @dav3r the gh actions on this PR are failing at the black hook id with this error:
ImportError: cannot import name '_unicodefun' from 'click'

I did a quick search and it seems a recent version of the click package is breaking which i'm assuming is a dependency of this hook:
dask/distributed#6013

how would you like me to move forward? Should I comment this hook out for now? Thanks

@dav3r
Copy link
Member

dav3r commented Mar 31, 2022

hey @dav3r the gh actions on this PR are failing at the black hook id with this error: ImportError: cannot import name '_unicodefun' from 'click'

I did a quick search and it seems a recent version of the click package is breaking which i'm assuming is a dependency of this hook: dask/distributed#6013

how would you like me to move forward? Should I comment this hook out for now? Thanks

You should be able to update your pre-commit hooks to get past this issue until we are able to push out a skeleton update that will address this. Please see cisagov/skeleton-generic#105 for more info. If you have any questions, @mcdonnnj will be happy to answer them. πŸ˜„

@itsmostafa
Copy link
Contributor Author

hey @dav3r the gh actions on this PR are failing at the black hook id with this error: ImportError: cannot import name '_unicodefun' from 'click'
I did a quick search and it seems a recent version of the click package is breaking which i'm assuming is a dependency of this hook: dask/distributed#6013
how would you like me to move forward? Should I comment this hook out for now? Thanks

You should be able to update your pre-commit hooks to get past this issue until we are able to push out a skeleton update that will address this. Please see cisagov/skeleton-generic#105 for more info. If you have any questions, @mcdonnnj will be happy to answer them. πŸ˜„

Sounds good I'll reach out to @mcdonnnj next time :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants