Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams not saved correctly #3444

Closed
LudwigSeitz opened this issue Aug 4, 2023 · 9 comments
Closed

Diagrams not saved correctly #3444

LudwigSeitz opened this issue Aug 4, 2023 · 9 comments

Comments

@LudwigSeitz
Copy link

LudwigSeitz commented Aug 4, 2023

🐛 Bug Report

In CSET version 11.5.1.0 when I run a diagram-based assessment, after drawing the diagram and proceeding to the assessment, the diagram is not saved correctly. The assessment runs on an early version of the diagram, losing all later edits. Even saved diagrams have lost later edits and revert to an early version of the diagram (c.a. 8 components, finished diagram had 50+).

To Reproduce

Steps to reproduce the behavior:

  1. Create a diagram-based Assessment
  2. In the diagram editor create a diagram with more than ~10 components
  3. Select File > Save as... to save diagram
  4. Select "Return to CSET"
    Observe the components listing missing the later edits of the diagram

Expected behavior

Diagram gets saved and transferred to assessment tool as drawn (latest edits included)

Any helpful log output

Finished diagram (intended): NIST example

Saved diagram (after proceeding to assessment tool): Save diagram

@LudwigSeitz
Copy link
Author

Here is an example diagram exported from the editor that reproduces the error (based on the NIST 800-82r3 example)
Waterstation.zip

@LudwigSeitz
Copy link
Author

In order to reproduce, try to edit the diagram. Changes are discarded.

@roland-paul-moraru
Copy link

Hello @LudwigSeitz, I'm also encountering the same issue. I noticed that if I make any changes, the network warnings are being updated and show the new warnings, but then the diagram goes back to the original one.

Did you manage to find a solution or a workaround to this? Thank you.

@LudwigSeitz
Copy link
Author

LudwigSeitz commented Nov 20, 2023

Sadly no, I'm waiting for a customer that I can use the tool at, to be able to spend more time on it :-)

@neronidis
Copy link

Hello, i am facing the same problem. I cannot find a pattern why this happens.
I have also tried to import a drawing from a visio file , function that in theory is supported , but without success.
Another test i did was to download the draw.io application locally, create a diagram and try to open the saved file with the CSET Tool. Also failed :-(

@alessandroZelli
Copy link

I have the same issue, it seems to be impossible to save or modify diagrams that are not presets.

@roland-paul-moraru
Copy link

@LudwigSeitz @alessandroZelli @neronidis a workaround I'm testing is to use older versions of the tool. Right now, I'm using CSET 8.1 and it looks like the diagrams, and any changes, are saved correctly. The tool's interface is different, of course, and I'm not sure yet if all functionalities are there.

@alessandroZelli
Copy link

@LudwigSeitz @roland-paul-moraru @neronidis I managed to work around the issue on the latest version with the following steps:

  1. Export the finished diagram as xml before saving.
  2. Close CSET
  3. Using SQL Server Management studio connect to the LocalDB instance in use with windows authorization (for me it was '(localdb)\INLLocalDb2022')
  4. Edit a diagram template you're not going to use (I took Solar Below 20MW) with the raw graph xml, starting from the tag and ending with the closing one . You might have to remove all indentation and linebreaks, depending on how long the raw xml is. The query is:
    UPDATE dbo.DIAGRAM_TEMPLATES SET Diagram_Markup='<rawxml>' WHERE Id=20;
  5. Reopen CSET, start a new network based diagram assessment and when prompted to pick a template pick the template corresponding to the modified Id.
  6. You now have an assessment with the correct diagram.

@martbillinl
Copy link

This is fixed in the version 12.1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants