Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to correctly handle truncated results as well as fix ClientError … #35

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Fix to correctly handle truncated results as well as fix ClientError … #35

merged 2 commits into from
Jun 28, 2019

Conversation

mcdonnnj
Copy link
Member

This PR fixes two issues with the AWS cleanup function.

  1. It was not correctly handling truncated results.
  2. The Multi-Object Delete operation requires a list of objects, but if the list is empty AWS will see it as malformed XML and return an error response.

@mcdonnnj
Fix to correctly handle truncated results as well as fix ClientError …
2091b68 
…exception when called with no files to delete.
@mcdonnnj mcdonnnj requested review from jsf9k, dav3r and felddy June 28, 2019 08:18
@mcdonnnj mcdonnnj self-assigned this Jun 28, 2019
@mcdonnnj mcdonnnj requested review from a team and removed request for a team, jsf9k, dav3r and felddy June 28, 2019 08:19
@jsf9k
Copy link
Member

jsf9k commented Jun 28, 2019

Is this PR ready for review? My review was requested, but it's marked as a draft PR.

@mcdonnnj mcdonnnj requested review from jsf9k, felddy and dav3r June 28, 2019 14:48
@mcdonnnj mcdonnnj marked this pull request as ready for review June 28, 2019 14:48
jsf9k
jsf9k approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

dav3r
dav3r approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 🥇

@mcdonnnj mcdonnnj merged commit 3d06e6e into develop Jun 28, 2019
@mcdonnnj mcdonnnj deleted the fix_aws_cleanup branch June 28, 2019 16:50
mcdonnnj pushed a commit that referenced this pull request Mar 26, 2020
@felddy
Merge pull request #35 from cisagov/improvement/static_type_checking
6369cc6 
Autoupdate pre-commit hooks.  Add mypy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcdonnnj @jsf9k @dav3r