Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include entity enrollment date in data extract #51

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jan 23, 2024

🗣 Description

This PR adds the enrolled field from RequestDoc to the data extracted with cyhy-data-extract.py.

💭 Motivation and context

The enrolled field was added to request documents recently (see cisagov/cyhy-core#86) and we want to include it in the data extract.

🧪 Testing

This change has not been tested, but I am confident it will work as expected since it is such a minuscule change.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Deploy this change to Production.

The "enrolled" field was added to request documents recently and we want to include it in the data extract.
@dav3r dav3r added the improvement This issue or pull request will add new or improve existing functionality label Jan 23, 2024
@dav3r dav3r requested a review from jasonodoom January 23, 2024 16:08
@dav3r dav3r self-assigned this Jan 23, 2024
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@dav3r dav3r merged commit 2691396 into develop Jan 24, 2024
49 checks passed
@dav3r dav3r deleted the improvement/add-enrolled-field-to-extract branch January 24, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add new or improve existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants