Use the latest cyhy-mailer Docker image everywhere #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR #84 I updated the cyhy-mailer Docker image version in docker-compose.yml, but the change did not take. I eventually figured out that this was because the image key (which was pointing to the previous version of the image) also exists in docker-compose.{bod,cyhy-notification,cyhy}.yml. To make it so that we only need update the image in a single place, I am removing the image key from docker-compose.{bod,cyhy-notification,cyhy}.yml.
jsf9k
force-pushed
the
bugfix/use-latest-docker-image-everywhere
branch
from
d13adcc
to
e9f6dfc
Compare
mcdonnnj
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request ensures that the latest version of the Docker cyhy-mailer Docker image is used.
💭 Motivation and context
In PR #84 I updated the cyhy-mailer Docker image version in
docker-compose.yml, but the change did not take. I eventually figured out that this was because theimagekey (which was pointing to the previous version of the image) also existed indocker-compose.{bod,cyhy-notification,cyhy}.yml. To make it so that we only need update the image in a single place, I am removing the redundantimagekey fromdocker-compose.{bod,cyhy-notification,cyhy}.yml.Thanks to @climber-girl for noticing the error.
🧪 Testing
All
pre-commithooks pass.✅ Checklist