-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default log level warning #104
Conversation
This will help prevent guacscanner logs from growing too large.
Pull Request Test Coverage Report for Build 3362436755
π - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π π Less disk!! πΎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't specifically have an issue with this, but do we want to instead change Docker behavior instead of limiting the logging information from this package? We could update cisagov/guacamole-composition to log to AWS CloudWatch or just adjust the retention rules for the default json-file
driver. I'm not a big fan of adjusting Python package behavior because of a downstream implementation problem when possible. Just for completeness all information about Docker logging configuration can be found here.
Closed in favor of adjusting the retention settings for the |
Please see cisagov/guacamole-composition#54 and cisagov/guacamole-composition#55. |
β¦script Fix overly match-happy sed commands
π£ Description
Make the default log level
warning
. This will help prevent guacscanner logs from growing too large.π Motivation and context
Resolves cisagov/guacamole-composition#54.π§ͺ Testing
All automated tests pass.
β Pre-approval checklist
β Pre-merge checklist
β Post-merge checklist