Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default log level warning #104

Closed
wants to merge 2 commits into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 28, 2022

πŸ—£ Description

Make the default log level warning. This will help prevent guacscanner logs from growing too large.

πŸ’­ Motivation and context

Resolves cisagov/guacamole-composition#54.

πŸ§ͺ Testing

All automated tests pass.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

This will help prevent guacscanner logs from growing too large.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number labels Oct 28, 2022
@jsf9k jsf9k self-assigned this Oct 28, 2022
@coveralls
Copy link

coveralls commented Oct 28, 2022

Pull Request Test Coverage Report for Build 3362436755

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.965%

Totals Coverage Status
Change from base Build 3146577391: 0.0%
Covered Lines: 218
Relevant Lines: 265

πŸ’› - Coveralls

@jsf9k jsf9k marked this pull request as ready for review October 28, 2022 20:28
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ πŸ‘ Less disk!! πŸ’Ύ

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't specifically have an issue with this, but do we want to instead change Docker behavior instead of limiting the logging information from this package? We could update cisagov/guacamole-composition to log to AWS CloudWatch or just adjust the retention rules for the default json-file driver. I'm not a big fan of adjusting Python package behavior because of a downstream implementation problem when possible. Just for completeness all information about Docker logging configuration can be found here.

@jsf9k
Copy link
Member Author

jsf9k commented Oct 31, 2022

Closed in favor of adjusting the retention settings for the json-file Docker logging driver in cisagov/guacamole-composition, as suggested by @mcdonnnj.

@jsf9k jsf9k closed this Oct 31, 2022
@jsf9k jsf9k reopened this Oct 31, 2022
@jsf9k jsf9k closed this Oct 31, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Oct 31, 2022

Please see cisagov/guacamole-composition#54 and cisagov/guacamole-composition#55.

cisagovbot pushed a commit that referenced this pull request Jan 7, 2023
…script

Fix overly match-happy sed commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the size of Docker logs
4 participants