Add IP addresses to Guacamole connection names #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
improvement
Pull Request Test Coverage Report for Build 1790836694
💛 - Coveralls |
jsf9k
added a commit
to cisagov/guacscanner-docker
that referenced
this pull request
Jan 31, 2022
This will pick up a fewupdates from cisagov/guacscanner: - cisagov/guacscanner#32 - cisagov/guacscanner#33
This was referenced Jan 31, 2022
Merged
Use this attribute as a unique identifier for the connection instead of the connection name. The connection name now contains the various IP addresses associated with the instance, so it could change without the actual instance ID changing. This is a better way to identify the connections associated with a particular instance ID anyway.
jsf9k
force-pushed
the
improvement/add-ip-addresses
branch
from
32c0f92
to
a833904
Compare
mcdonnnj
approved these changes
Feb 3, 2022
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
jsf9k
force-pushed
the
improvement/add-ip-addresses
branch
3 times, most recently
from
8720b42
to
5cc9814
Compare
This is to prepare for dropping support for Python 3.7, which will be done in a future commit. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
I want to use the walrus operator in a future commit, so we require at least Python 3.8. I've also been building a Python 3.10 Docker image in cisagov/guacscanner-docker and running this code there, so we know 3.10 is supported. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
jsf9k
force-pushed
the
improvement/add-ip-addresses
branch
from
5cc9814
to
9244182
Compare
jsf9k
added a commit
to cisagov/guacscanner-docker
that referenced
this pull request
Jul 17, 2023
This will pick up a fewupdates from cisagov/guacscanner: - cisagov/guacscanner#32 - cisagov/guacscanner#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds private IPv4, public IPv4, and IPv6 addresses to the Guacamole connection name if such addresses exist.
💭 Motivation and context
This was requested in cisagov/cool-system-internal#43.
🧪 Testing
Automated testing passes. I also created a new COOL staging AMI from these changes and verified that it functions as expected.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist